Skip to content

[ABLD-77] Bump dda version to bring dmgbuild for macOS #38446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[ABLD-77] Bump dda version to bring dmgbuild for macOS #38446

wants to merge 2 commits into from
+13 −13

Conversation

rdesgroppes
Copy link

What does this PR do?

Since available Python build dependencies rely on the version of dda, the present change bumps it to bring the dmgbuild tool for macOS.

Motivation

See https://github.com/DataDog/datadog-agent-dev/releases/tag/v0.19.0, and esp. DataDog/datadog-agent-dev#137.

Possible Drawbacks / Trade-offs

The PR is kept trivial (revertible) as other changes were brought to dda since last bump from March 2025.

@rdesgroppes rdesgroppes changed the title Bump dda version to bring dmgbuild for macOS [ABLD-77] Bump dda version to bring dmgbuild for macOS Jul 3, 2025
@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/bump-dda-for-dmgbuild-dep branch 3 times, most recently from e37b5a5 to 12eb9ab Compare July 3, 2025 15:45
@github-actions github-actions bot added short review PR is simple enough to be reviewed quickly team/agent-devx labels Jul 3, 2025
@rdesgroppes rdesgroppes added dependencies PRs that bump a dependency and removed short review PR is simple enough to be reviewed quickly team/agent-devx labels Jul 3, 2025
@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/bump-dda-for-dmgbuild-dep branch from 12eb9ab to b42d77c Compare July 3, 2025 16:50
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Jul 3, 2025
@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/bump-dda-for-dmgbuild-dep branch 2 times, most recently from 83f93db to 9100fb3 Compare July 4, 2025 17:05
@cit-pr-commenter cit-pr-commenter
Copy link

cit-pr-commenter bot commented Jul 4, 2025 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: efc46c0b-4c2a-466e-93b6-67afc09baab7

Baseline: 6fc3b6a
Comparison: 5310dc5
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ uds_dogstatsd_to_api_cpu % cpu utilization +0.73 [-0.13, +1.59] 1 Logs
➖ quality_gate_idle memory utilization +0.63 [+0.56, +0.70] 1 Logs bounds checks dashboard
➖ file_tree memory utilization +0.62 [+0.49, +0.76] 1 Logs
➖ otlp_ingest_metrics memory utilization +0.39 [+0.25, +0.54] 1 Logs
➖ docker_containers_cpu % cpu utilization +0.14 [-2.90, +3.19] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput +0.04 [-0.59, +0.66] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput +0.01 [-0.22, +0.24] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.02] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput -0.00 [-0.61, +0.61] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput -0.01 [-0.28, +0.26] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput -0.01 [-0.56, +0.54] 1 Logs
➖ ddot_logs memory utilization -0.02 [-0.11, +0.08] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput -0.02 [-0.63, +0.59] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.05 [-0.60, +0.50] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput -0.07 [-0.64, +0.50] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput -0.11 [-0.66, +0.43] 1 Logs
➖ ddot_metrics memory utilization -0.13 [-0.25, -0.01] 1 Logs
➖ docker_containers_memory memory utilization -0.19 [-0.27, -0.12] 1 Logs
➖ quality_gate_logs % cpu utilization -0.24 [-2.99, +2.50] 1 Logs bounds checks dashboard
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.29 [-0.34, -0.24] 1 Logs
➖ quality_gate_idle_all_features memory utilization -0.29 [-0.36, -0.22] 1 Logs bounds checks dashboard
➖ otlp_ingest_logs memory utilization -0.45 [-0.57, -0.32] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput -0.61 [-0.67, -0.56] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@rdesgroppes
Bump dda version to bring dmgbuild for macOS
662dcf7 
Since available Python build dependencies rely on the version of `dda`,
the present change bumps it to bring the `dmgbuild` tool for macOS.

See https://github.com/DataDog/datadog-agent-dev/releases/tag/v0.19.0,
and esp. DataDog/datadog-agent-dev#137.

The PR is kept trivial (revertible) as other changes were brought to
`dda` since last bump from March 2025.
@rdesgroppes
tmp
5310dc5
@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/bump-dda-for-dmgbuild-dep branch from 9100fb3 to 5310dc5 Compare July 7, 2025 10:36
@rdesgroppes rdesgroppes added the qa/no-code-change No code change in Agent code requiring validation label Jul 7, 2025
@agent-platform-auto-pr
Copy link
Contributor

Gitlab CI Configuration Changes

Modified Jobs

variables (configuration) 
  variables:
    AGENT_API_KEY_ORG2: agent-api-key-org-2
    AGENT_APP_KEY_ORG2: agent-app-key-org-2
    AGENT_BINARIES_DIR: bin/agent
    AGENT_GITHUB_APP: agent-github-app
    AGENT_QA_E2E: agent-qa-e2e
    API_KEY_ORG2: ci.datadog-agent.datadog_api_key_org2
    ARTIFACT_DOWNLOAD_ATTEMPTS: 2
    ATLASSIAN_WRITE: atlassian-write
    BTFHUB_ARCHIVE_BRANCH: main
    BUCKET_BRANCH: dev
    CHANGELOG_COMMIT_SHA: ci.datadog-agent.gitlab_changelog_commit_sha
    CHOCOLATEY_API_KEY: ci.datadog-agent.chocolatey_api_key
-   CI_IMAGE_BTF_GEN: v69654555-575d560a
+   CI_IMAGE_BTF_GEN: v69727762-445b8925
    CI_IMAGE_BTF_GEN_SUFFIX: ''
-   CI_IMAGE_DEB_ARM64: v69654555-575d560a
+   CI_IMAGE_DEB_ARM64: v69727762-445b8925
    CI_IMAGE_DEB_ARM64_SUFFIX: ''
-   CI_IMAGE_DEB_ARMHF: v69654555-575d560a
+   CI_IMAGE_DEB_ARMHF: v69727762-445b8925
    CI_IMAGE_DEB_ARMHF_SUFFIX: ''
-   CI_IMAGE_DEB_X64: v69654555-575d560a
+   CI_IMAGE_DEB_X64: v69727762-445b8925
    CI_IMAGE_DEB_X64_SUFFIX: ''
-   CI_IMAGE_DOCKER_ARM64: v69654555-575d560a
+   CI_IMAGE_DOCKER_ARM64: v69727762-445b8925
    CI_IMAGE_DOCKER_ARM64_SUFFIX: ''
-   CI_IMAGE_DOCKER_X64: v69654555-575d560a
+   CI_IMAGE_DOCKER_X64: v69727762-445b8925
    CI_IMAGE_DOCKER_X64_SUFFIX: ''
-   CI_IMAGE_GITLAB_AGENT_DEPLOY: v69654555-575d560a
?                                     ^   ----------
+   CI_IMAGE_GITLAB_AGENT_DEPLOY: v69727762-445b8925
?                                    ++++ ^^^  ++++
    CI_IMAGE_GITLAB_AGENT_DEPLOY_SUFFIX: ''
-   CI_IMAGE_LINUX_GLIBC_2_17_X64: v69654555-575d560a
?                                      ^   ----------
+   CI_IMAGE_LINUX_GLIBC_2_17_X64: v69727762-445b8925
?                                     ++++ ^^^  ++++
    CI_IMAGE_LINUX_GLIBC_2_17_X64_SUFFIX: ''
-   CI_IMAGE_LINUX_GLIBC_2_23_ARM64: v69654555-575d560a
?                                        ^   ----------
+   CI_IMAGE_LINUX_GLIBC_2_23_ARM64: v69727762-445b8925
?                                       ++++ ^^^  ++++
    CI_IMAGE_LINUX_GLIBC_2_23_ARM64_SUFFIX: ''
-   CI_IMAGE_RPM_ARM64: v69654555-575d560a
+   CI_IMAGE_RPM_ARM64: v69727762-445b8925
    CI_IMAGE_RPM_ARM64_SUFFIX: ''
-   CI_IMAGE_RPM_ARMHF: v69654555-575d560a
+   CI_IMAGE_RPM_ARMHF: v69727762-445b8925
    CI_IMAGE_RPM_ARMHF_SUFFIX: ''
-   CI_IMAGE_RPM_X64: v69654555-575d560a
+   CI_IMAGE_RPM_X64: v69727762-445b8925
    CI_IMAGE_RPM_X64_SUFFIX: ''
    CI_IMAGE_WIN_LTSC2022_X64: v68287210-66c494d7
    CI_IMAGE_WIN_LTSC2022_X64_SUFFIX: ''
    CLANG_BUILD_VERSION: v60409452-ee70de70
    CLANG_LLVM_VER: 12.0.1
    CLUSTER_AGENT_BINARIES_DIR: bin/datadog-cluster-agent
    CLUSTER_AGENT_CLOUDFOUNDRY_BINARIES_DIR: bin/datadog-cluster-agent-cloudfoundry
    CODECOV: codecov
    CODECOV_TOKEN: ci.datadog-agent.codecov_token
    COMPARE_TO_BRANCH: main
    CWS_INSTRUMENTATION_BINARIES_DIR: bin/cws-instrumentation
    DATADOG_AGENT_EMBEDDED_PATH: /opt/datadog-agent/embedded
    DD_AGENT_TESTING_DIR: $CI_PROJECT_DIR/test/new-e2e/tests
    DD_PKG_VERSION: latest
    DEB_GPG_KEY: ci.datadog-agent.deb_signing_private_key_${DEB_GPG_KEY_ID}
    DEB_GPG_KEY_ID: c0962c7d
    DEB_GPG_KEY_NAME: Datadog, Inc. APT key
    DEB_RPM_TESTING_BUCKET_BRANCH: testing
    DEB_S3_BUCKET: apt.datad0g.com
    DEB_SIGNING_PASSPHRASE: ci.datadog-agent.deb_signing_key_passphrase_${DEB_GPG_KEY_ID}
    DEB_TESTING_S3_BUCKET: apttesting.datad0g.com
    DOCKER_REGISTRY_LOGIN: ci.datadog-agent.docker_hub_login
    DOCKER_REGISTRY_PWD: ci.datadog-agent.docker_hub_pwd
    DOCKER_REGISTRY_RO: dockerhub-readonly
    DOCKER_REGISTRY_URL: docker.io
    DOGSTATSD_BINARIES_DIR: bin/dogstatsd
    E2E_AZURE: e2e-azure
    E2E_GCP: e2e-gcp
    EXECUTOR_JOB_SECTION_ATTEMPTS: 2
    FF_KUBERNETES_HONOR_ENTRYPOINT: true
    FF_SCRIPT_SECTIONS: 1
    FF_TIMESTAMPS: true
    GENERAL_ARTIFACTS_CACHE_BUCKET_URL: https://dd-agent-omnibus.s3.amazonaws.com
    GET_SOURCES_ATTEMPTS: 2
    GITLAB_TOKEN: gitlab-token
    GO_TEST_SKIP_FLAKE: 'true'
    INSTALLER_TESTING_S3_BUCKET: installtesting.datad0g.com
    INSTALL_SCRIPT_API_KEY_ORG2: install-script-api-key-org-2
    INTEGRATION_WHEELS_CACHE_BUCKET: dd-agent-omnibus
    KERNEL_MATRIX_TESTING_ARM_AMI_ID: ami-0b5f838a19d37fc61
    KERNEL_MATRIX_TESTING_X86_AMI_ID: ami-05b3973acf5422348
    KITCHEN_INFRASTRUCTURE_FLAKES_RETRY: 2
    MACOS_APPLE_APPLICATION_SIGNING: apple-application-signing
    MACOS_APPLE_DEVELOPER_ACCOUNT: apple-developer-account
    MACOS_APPLE_INSTALLER_SIGNING: apple-installer-signing
    MACOS_GITHUB_APP_1: macos-github-app-one
    MACOS_GITHUB_APP_2: macos-github-app-two
    MACOS_KEYCHAIN_PWD: ci-keychain
    MACOS_S3_BUCKET: dd-agent-macostesting
    OMNIBUS_BASE_DIR: /omnibus
    OMNIBUS_GIT_CACHE_DIR: /tmp/omnibus-git-cache
    OMNIBUS_PACKAGE_DIR: $CI_PROJECT_DIR/omnibus/pkg/
    OMNIBUS_PACKAGE_DIR_SUSE: $CI_PROJECT_DIR/omnibus/suse/pkg
    PIPELINE_KEY_ALIAS: alias/ci_datadog-agent_pipeline-key
    PROCESS_S3_BUCKET: datad0g-process-agent
    RESTORE_CACHE_ATTEMPTS: 2
    RPM_GPG_KEY: ci.datadog-agent.rpm_signing_private_key_${RPM_GPG_KEY_ID}
    RPM_GPG_KEY_ID: b01082d3
    RPM_GPG_KEY_NAME: Datadog, Inc. RPM key
    RPM_S3_BUCKET: yum.datad0g.com
    RPM_SIGNING_PASSPHRASE: ci.datadog-agent.rpm_signing_key_passphrase_${RPM_GPG_KEY_ID}
    RPM_TESTING_S3_BUCKET: yumtesting.datad0g.com
    RUN_E2E_TESTS: auto
    RUN_KMT_TESTS: auto
    RUN_UNIT_TESTS: auto
    S3_ARTIFACTS_URI: s3://dd-ci-artefacts-build-stable/$CI_PROJECT_NAME/$CI_PIPELINE_ID
    S3_CP_CMD: aws s3 cp $S3_CP_OPTIONS
    S3_CP_OPTIONS: --no-progress --region us-east-1 --sse AES256
    S3_DD_AGENT_OMNIBUS_BTFS_URI: s3://dd-agent-omnibus/btfs
    S3_DD_AGENT_OMNIBUS_JAVA_URI: s3://dd-agent-omnibus/openjdk
    S3_DD_AGENT_OMNIBUS_LLVM_URI: s3://dd-agent-omnibus/llvm
    S3_DSD6_URI: s3://dsd6-staging
    S3_OMNIBUS_CACHE_BUCKET: dd-ci-datadog-agent-omnibus-cache-build-stable
    S3_OMNIBUS_GIT_CACHE_BUCKET: dd-ci-datadog-agent-omnibus-git-cache-build-stable
    S3_PERMANENT_ARTIFACTS_URI: s3://dd-ci-persistent-artefacts-build-stable/$CI_PROJECT_NAME
    S3_PROJECT_ARTIFACTS_URI: s3://dd-ci-artefacts-build-stable/$CI_PROJECT_NAME
    S3_RELEASE_ARTIFACTS_URI: s3://dd-release-artifacts/$CI_PROJECT_NAME/$CI_PIPELINE_ID
    S3_RELEASE_INSTALLER_ARTIFACTS_URI: s3://dd-release-artifacts/datadog-installer/$CI_PIPELINE_ID
    S3_SBOM_STORAGE_URI: s3://sbom-root-us1-ddbuild-io/$CI_PROJECT_NAME/$CI_PIPELINE_ID
    SLACK_AGENT: slack-agent-ci
    SMP_ACCOUNT: smp
    STATIC_BINARIES_DIR: bin/static
    SYSTEM_PROBE_BINARIES_DIR: bin/system-probe
    VCPKG_BLOB_SAS_URL: ci.datadog-agent-buildimages.vcpkg_blob_sas_url
    VIRUS_TOTAL: virus-total
    WINDOWS_BUILDS_S3_BUCKET: $WIN_S3_BUCKET/builds
    WINDOWS_POWERSHELL_DIR: $CI_PROJECT_DIR/signed_scripts
    WINDOWS_TESTING_S3_BUCKET: pipelines/A7/$CI_PIPELINE_ID
    WINGET_PAT: ci.datadog-agent.winget_pat
    WIN_S3_BUCKET: dd-agent-mstesting

Changes Summary

Removed Modified Added Renamed
0 1 0 0

ℹ️ Diff available in the job log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies PRs that bump a dependency qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-devx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rdesgroppes